Change in osmo-sgsn[master]: gb_proxy_peer: Add some FIXMEs regarding invalid assumptions

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21312 )

Change subject: gb_proxy_peer: Add some FIXMEs regarding invalid assumptions
......................................................................

gb_proxy_peer: Add some FIXMEs regarding invalid assumptions

Change-Id: Ibf3d4a3bd58e706dfa44e8cc9ff4823a7759dea5
---
M src/gbproxy/gb_proxy_peer.c
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve



diff --git a/src/gbproxy/gb_proxy_peer.c b/src/gbproxy/gb_proxy_peer.c
index 48482b6..cb76a59 100644
--- a/src/gbproxy/gb_proxy_peer.c
+++ b/src/gbproxy/gb_proxy_peer.c
@@ -105,6 +105,7 @@
 }
 
 /* look-up a peer by its Routeing Area Identification (RAI) */
+/* FIXME: this doesn't make sense, as RA can span multiple peers! */
 struct gbproxy_peer *gbproxy_peer_by_rai(struct gbproxy_config *cfg,
 					 const uint8_t *ra)
 {
@@ -117,6 +118,7 @@
 }
 
 /* look-up a peer by its Location Area Identification (LAI) */
+/* FIXME: this doesn't make sense, as LA can span multiple peers! */
 struct gbproxy_peer *gbproxy_peer_by_lai(struct gbproxy_config *cfg,
 					 const uint8_t *la)
 {
@@ -129,6 +131,7 @@
 }
 
 /* look-up a peer by its Location Area Code (LAC) */
+/* FIXME: this doesn't make sense, as LAC can span multiple peers! */
 struct gbproxy_peer *gbproxy_peer_by_lac(struct gbproxy_config *cfg,
 					 const uint8_t *la)
 {
@@ -151,6 +154,7 @@
 			return gbproxy_peer_by_bvci(cfg, bvci);
 	}
 
+	/* FIXME: this doesn't make sense, as RA can span multiple peers! */
 	if (TLVP_PRESENT(tp, BSSGP_IE_ROUTEING_AREA)) {
 		uint8_t *rai = (uint8_t *)TLVP_VAL(tp, BSSGP_IE_ROUTEING_AREA);
 		/* Only compare LAC part, since MCC/MNC are possibly patched.
@@ -159,6 +163,7 @@
 		return gbproxy_peer_by_lac(cfg, rai);
 	}
 
+	/* FIXME: this doesn't make sense, as LA can span multiple peers! */
 	if (TLVP_PRESENT(tp, BSSGP_IE_LOCATION_AREA)) {
 		uint8_t *lai = (uint8_t *)TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA);
 		return gbproxy_peer_by_lac(cfg, lai);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21312
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ibf3d4a3bd58e706dfa44e8cc9ff4823a7759dea5
Gerrit-Change-Number: 21312
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201130/482974b5/attachment.htm>