This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 ) Change subject: l1sap: add repeated downlink FACCH ...................................................................... Patch Set 11: (2 comments) This change is ready for review. https://gerrit.osmocom.org/c/osmo-bts/+/21014/10/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/10/src/common/l1sap.c@1131 PS10, Line 1131: /* The +2 is empty space where the DSP inserts the L1 hdr */ > we probably have the l1header struct somewhere, so you could use sizeof() of that struct instead of […] I have looked through the headers in libosmocore, but I couln't find a header struct. Also the code around does not use a struct. https://gerrit.osmocom.org/c/osmo-bts/+/21014/10/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/21014/10/src/common/rsl.c@829 PS10, Line 829: msgb_free(lchan->tch.rep_facch[0].msg); > I'd expect msgb_free() to accept NULL pointers. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75 Gerrit-Change-Number: 21014 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Sat, 28 Nov 2020 21:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201128/f262cc99/attachment.htm>