Change in osmo-mgw[master]: mgcp_vty: add missing VTY commands for E1 trunks

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Nov 27 10:18:22 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/21364 )

Change subject: mgcp_vty: add missing VTY commands for E1 trunks
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/21364/2/src/libosmo-mgcp/mgcp_vty.c 
File src/libosmo-mgcp/mgcp_vty.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/21364/2/src/libosmo-mgcp/mgcp_vty.c@1676 
PS2, Line 1676: 	install_element(TRUNK_NODE, &cfg_trunk_force_realloc_cmd);
Can't you simply in general reuse the same function? ex:
install_element(TRUNK_NODE, &cfg_mgcp_force_realloc_cmd);



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/21364
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ief2bc7502bb8d1e0f9c784d42edbe1aed5ffb728
Gerrit-Change-Number: 21364
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 27 Nov 2020 10:18:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201127/6678c8b0/attachment.htm>


More information about the gerrit-log mailing list