Change in osmo-bts[master]: l1sap: add repeated downlink SACCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Nov 26 12:37:15 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21105 )

Change subject: l1sap: add repeated downlink SACCH
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21105/6/src/common/rsl.c 
File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21105/6/src/common/rsl.c@834 
PS6, Line 834: if (lchan->rep_sacch)
> like all free() functions, msgb_free() should always be safe to call with a NULL pointer. […]
+1, better if you rework this patch imho :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21105
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I00806f936b15fbaf6a4e7bbd61f3bec262cdbb28
Gerrit-Change-Number: 21105
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 26 Nov 2020 12:37:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201126/fdb4e0a6/attachment.htm>


More information about the gerrit-log mailing list