Change in mncc-python[master]: main: generate coredump and exit upon SIGABRT received

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/mncc-python/+/21341 )

Change subject: main: generate coredump and exit upon SIGABRT received
......................................................................

main: generate coredump and exit upon SIGABRT received

Previous code relied on abort() switching sigaction to SIG_FDL +
retriggering SIGABRT in case the signal handler returns, which would
then generate the coredump + terminate the process.
However, if a SIGABRT is received from somewhere else (kill -SIGABRT),
then the process would print the talloc report and continue running,
which is not desired.

Fixes: OS#4865
Change-Id: I3caa78e6ce7c9a98b0a26fde61468bd7b38c6fd9
---
M rtpsource/rtpsource.c
1 file changed, 10 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Verified



diff --git a/rtpsource/rtpsource.c b/rtpsource/rtpsource.c
index d5ffce5..d966a4f 100644
--- a/rtpsource/rtpsource.c
+++ b/rtpsource/rtpsource.c
@@ -198,8 +198,16 @@
 {
 	switch (signal) {
 	case SIGABRT:
-		/* in case of abort, we want to obtain a talloc report
-		 * and then return to the caller, who will abort the process */
+		/* in case of abort, we want to obtain a talloc report and
+		 * then run default SIGABRT handler, who will generate coredump
+		 * and abort the process. abort() should do this for us after we
+		 * return, but program wouldn't exit if an external SIGABRT is
+		 * received.
+		 */
+		talloc_report_full(g_tall_ctx, stderr);
+		signal(SIGABRT, SIG_DFL);
+		raise(SIGABRT);
+		break;
 	case SIGUSR1:
 		talloc_report_full(g_tall_ctx, stderr);
 		break;

-- 
To view, visit https://gerrit.osmocom.org/c/mncc-python/+/21341
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: mncc-python
Gerrit-Branch: master
Gerrit-Change-Id: I3caa78e6ce7c9a98b0a26fde61468bd7b38c6fd9
Gerrit-Change-Number: 21341
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201125/b13075ec/attachment.htm>