Change in osmo-ttcn3-hacks[master]: gbproxy: Port TC_{suspend, resume} to new GLOBAL port

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21325 )

Change subject: gbproxy: Port TC_{suspend,resume} to new GLOBAL port
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21325/2/gbproxy/GBProxy_Tests.ttcn 
File gbproxy/GBProxy_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21325/2/gbproxy/GBProxy_Tests.ttcn@604 
PS2, Line 604: friend function f_global_pcu2sgsn(template (value) PDU_BSSGP tx, template (present) PDU_BSSGP exp_rx,
> Wouldn't it make more sense to pass the ports as parameters instead of having the same function here […]
that only works if the ports are of the same type, which they are not here (For good reason, as the two ports have different feature sets).



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21325
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I805372f3024a0ec2491a24422e02c0bc6dc669d2
Gerrit-Change-Number: 21325
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: daniel <dwillmann at sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Wed, 25 Nov 2020 16:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201125/871f0523/attachment.htm>