This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21309 ) Change subject: gbproxy: Properly implement paging to LAC/RAC ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-sgsn/+/21309/1/src/gbproxy/gb_proxy.c File src/gbproxy/gb_proxy.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/21309/1/src/gbproxy/gb_proxy.c@1133 PS1, Line 1133: if (!memcmp(peer->ra, TLVP_VAL(tp, BSSGP_IE_LOCATION_AREA), 5)) { > is this correct? compare location are against peer->ra? ra contains the raw RAI field (04.08 Ch.10.5.5.15) which is the same as the LAI (04.08 Ch.10.5.1.3) plus the routing area octet at the end. That's why this is comparing 5 bytes instead of 6 above. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21309 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2c44959661fb53730586f4347cbfbbcece065e13 Gerrit-Change-Number: 21309 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Wed, 25 Nov 2020 13:42:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201125/d4062b9b/attachment.htm>