Change in osmo-gsm-tester[master]: process.py: Add execution of local processes

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 23 19:41:49 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21299 )

Change subject: process.py: Add execution of local processes
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21299/1/src/osmo_gsm_tester/core/process.py 
File src/osmo_gsm_tester/core/process.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21299/1/src/osmo_gsm_tester/core/process.py@454 
PS1, Line 454:     proc.launch()
You cannot do this, since you must track the process object from before you launch it, otherwise it an exception occurs you may leave the process running in the background, that's why other functions use launch_sync (which takes care of exceptions happening and killing the process iirc).
See testenv.remember_to_stop().



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21299
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I627acfefa1b476ebb767f6af44ba717db79afd51
Gerrit-Change-Number: 21299
Gerrit-PatchSet: 1
Gerrit-Owner: ninjab3s <nils.fuerste at softwareradiosystems.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Nov 2020 19:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201123/7b44937b/attachment.htm>


More information about the gerrit-log mailing list