Change in osmo-bts[master]: l1sap: add repeated downlink FACCH

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 )

Change subject: l1sap: add repeated downlink FACCH
......................................................................


Patch Set 10:

(5 comments)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@968 
PS9, Line 968: define DL_FACCH_REPETITION_THRESHOLD_UPPER 4
             : #define DL_FACCH_REPETITION_THRESHOLD_LOWER 3
> doesn't it make sense to have those vty/user configurable?  Or is there a specific rationale to deci […]
Done


https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@973 
PS9, Line 973: uint8_t
> const
Done


https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@974 
PS9, Line 974: int
> size_t or unsigned int, it cannot be negative
Done


https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/l1sap.c@976 
PS9, Line 976: meas_res
> const
Done


https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/rsl.c 
File src/common/rsl.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21014/9/src/common/rsl.c@832 
PS9, Line 832: memset
> Is memset() really needed here? For just two pointers, setting to NULL makes more sense.
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75
Gerrit-Change-Number: 21014
Gerrit-PatchSet: 10
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 20 Nov 2020 17:57:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201120/d9fc717c/attachment.htm>