Change in osmo-bts[master]: l1sap: pre-initalize pointer with NULL to avoid gcc warning

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21256 )

Change subject: l1sap: pre-initalize pointer with NULL to avoid gcc warning
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21256/1/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21256/1/src/common/l1sap.c@993 
PS1, Line 993: f (lchan->ts->trx->bts->dtxd)
             : 				dtxd_facch = true;
             : 			le = &lchan->lapdm_ch.lapdm_dcch;
what if we take this path? then "p" is still pointing to random mmeory (or NULL with your patch) and .... (tbc)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21256
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ibfd18ed5268740cc73fffdb950b96c7f0fad3164
Gerrit-Change-Number: 21256
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 19 Nov 2020 17:20:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201119/50948a56/attachment.htm>