Change in osmo-bsc[master]: bts: add repeated acch mode flags + vty config

[dexter]

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21164 )

Change subject: bts: add repeated acch mode flags + vty config
......................................................................


Patch Set 5:

(4 comments)

thanks for your review

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3//COMMIT_MSG 
Commit Message:

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3//COMMIT_MSG@10 
PS3, Line 10: a one byte flag is sent
> this patch does not send anything, all i can see is an unused vty config option. […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/include/osmocom/bsc/bts.h 
File include/osmocom/bsc/bts.h:

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/include/osmocom/bsc/bts.h@485 
PS3, Line 485: 	struct abis_rsl_osmo_rep_acch_cap repeated_acch_capability_bts;
> (this is a member of struct gsm_bts, redundant to also name the member *_bts)
I have given this member the _bts suffix because I want to express that this are the flag that the BTS supports. There will be also a struct member in gsm_subscriber_connection with the name repeated_acch_capability that tells what the MS supports.


https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c 
File src/osmo-bsc/bsc_vty.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c@2646 
PS3, Line 2646: 		vty_out(vty, "%% repeated ACCH not supported by this BTS%s",
> would be good to add the BTS number: during program startup, you'd read a lone "this BTS" and wouldn […]
Done


https://gerrit.osmocom.org/c/osmo-bsc/+/21164/3/src/osmo-bsc/bsc_vty.c@2651 
PS3, Line 2651: 	if (argv[0][0] == 'c') {
> i also did it like this some years back and got the code review that i should rather use a strcmp()  […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21164
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I083eaa2c30478912426e9c24a506f0b88836e190
Gerrit-Change-Number: 21164
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 19 Nov 2020 11:45:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201119/a31428a2/attachment.htm>