Change in libosmocore[master]: ns2: Add a function to reset the NSVC

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21231 )

Change subject: ns2: Add a function to reset the NSVC
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmocore/+/21231/1/src/gb/gprs_ns2_vc_fsm.c 
File src/gb/gprs_ns2_vc_fsm.c:

https://gerrit.osmocom.org/c/libosmocore/+/21231/1/src/gb/gprs_ns2_vc_fsm.c@632 
PS1, Line 632: 	switch (priv->nsvc->mode) {
> No, the reset event indicates that a RESET PDU has been received. […]
well I didn't mean the existing RESET event (I didn't even know there was one), I'm simply saying this kind of code you are adding here looks like should be handled inside the FSM code, so you should send an event, name it however you want. Of course receiving a RESET and Initiating a RESET are 2 different events.



-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21231
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If96d56b19959372af4eba009661be19e985b4d51
Gerrit-Change-Number: 21231
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Nov 2020 13:58:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201118/d8b32b56/attachment.htm>