Change in osmo-sgsn[master]: gprs_gb_parse: Add function to determine TLLI from encoded BSSGP

[pespin]

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/21227 )

Change subject: gprs_gb_parse: Add function to determine TLLI from encoded BSSGP
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-sgsn/+/21227/1/src/gprs/gprs_gb_parse.c 
File src/gprs/gprs_gb_parse.c:

https://gerrit.osmocom.org/c/osmo-sgsn/+/21227/1/src/gprs/gprs_gb_parse.c@465 
PS1, Line 465: 		bgph = NULL;
no real need for this, but ok.


https://gerrit.osmocom.org/c/osmo-sgsn/+/21227/1/src/gprs/gprs_gb_parse.c@472 
PS1, Line 472: 	if (budh) {
budh can only be non null on the if clause above, so it probably make sense to move it there too.
Then the other parts can also be moved to the else clause, and data + data_len can also be dropped from the if condition?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/21227
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia6d5300e63ad23987cbdca824db620305bd583d7
Gerrit-Change-Number: 21227
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Nov 2020 12:10:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201118/206e734a/attachment.htm>