Change in osmo-ttcn3-hacks[master]: NS_Emulation: Fail if an unsupported NS provider is chosen

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue Nov 17 19:11:26 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21212 )

Change subject: NS_Emulation: Fail if an unsupported NS provider is chosen
......................................................................

NS_Emulation: Fail if an unsupported NS provider is chosen

This took me quite some time: Tried to use NS_PROVIDER_FR, but the
code was compiled without support for it.  It just failed silently
without printing any error or ever sending any message on the FR link.

Change-Id: I96475127a2079830b3456a8e288adf4c6c908887
---
M library/NS_Emulation.ttcnpp
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved



diff --git a/library/NS_Emulation.ttcnpp b/library/NS_Emulation.ttcnpp
index 19de9d3..2e03880 100644
--- a/library/NS_Emulation.ttcnpp
+++ b/library/NS_Emulation.ttcnpp
@@ -382,6 +382,8 @@
 			connect(self:NSCP, vc_NSP_FR:NSE);
 			vc_NSP_FR.start(NS_Provider_FR.main(g_nsvc_config, g_config, id));
 #endif
+		} else {
+			Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Unsupported NS provider");
 		}
 
 		f_change_state(NSVC_S_DEAD_BLOCKED);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21212
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I96475127a2079830b3456a8e288adf4c6c908887
Gerrit-Change-Number: 21212
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/5b8b8941/attachment.htm>


More information about the gerrit-log mailing list