Change in osmo-bsc[master]: handover_test: allow arbitrary timeslot config and multiple TRX

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

neels gerrit-no-reply at lists.osmocom.org
Tue Nov 17 16:24:04 UTC 2020


neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21195 )

Change subject: handover_test: allow arbitrary timeslot config and multiple TRX
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21195/2/tests/handover/handover_test.c 
File tests/handover/handover_test.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21195/2/tests/handover/handover_test.c@180 
PS2, Line 180: 	if (!strcmp(str, "dyn"))
> osmodyn?
hmm... maybe dyn-fh and dyn-f? it's just an optional shortcut anyway.

(the main idea to have shortcuts at all is to allow listing timeslot configs and later expect-ts-use with tabs so that each timeslot perfectly lines up with those above, so i'd need names <= 7 chars.
That was paired with the idea of moving these test scripts from the current string arrays out to actual text files, which i think would be rather nicer but i also think might not be worth the effort so postponing that... so right now, when each and every arg also needs quotes and a comma like '"xxx",' the whole idea of tabs is moot ... all of this is just cosmetic bikeshed bla bla of course)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21195
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ic645cea671aa4798804666b8886f11bab5351e11
Gerrit-Change-Number: 21195
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Nov 2020 16:24:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/56a26393/attachment.htm>


More information about the gerrit-log mailing list