This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21206 ) Change subject: speed up py tests: add --fast-shutdown option to osmo-bsc ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/21206/2/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/21206/2/src/osmo-bsc/osmo_bsc_main.c@701 PS2, Line 701: sleep(3); > Why is this sleep added here in first place? Looks like a hack to me. […] a discussion on IRC reveals: "it just ensures that the write queues on Abis are drained" " makes sure that the OML shutdown messages are actually sent out to the BTS" " particularly important for E1 BTSs which (at least in the case of Siemens BS-11) continue to transmit if the BSC shuts down unclean" and a better solution than the sleep() would be to continue the select loop until all write queues are empty: after the shutdown signal is emitted, set a global bool that exits the loop when all queued messages were dispatched. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21206 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I506349c532b13751f674e4b9a132219d823f19e1 Gerrit-Change-Number: 21206 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2020 16:06:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/c7ab2d78/attachment.htm>