This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Hoernchen gerrit-no-reply at lists.osmocom.orgHoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/21071 ) Change subject: 7816 fsm: move to static msgb ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: > > > Couldn't we simply allocate teh msgb's once (from heap) at start and never free them at runtime, using msgb_reset or the like once they are recycled? > > any feedback here? I see this as a structured approach to move away from msgbs for those static buffers without trying to fix everything at once, which already didn't work so well half a year ago. This, however, works. The combined memory overhead of talloc and msgbs is already so large, it feels like embedded java, while contributing very little in this case, and talloc makes debugging things that should be plain old arrays or reasoning about wurst-käse memory allocations difficult - neither of which are things i'd like to see when doing embedded work. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/21071 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I65e77c376aca9ed50e234a0b58a7450a8bbd4fe0 Gerrit-Change-Number: 21071 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Tue, 17 Nov 2020 10:39:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/b462eca0/attachment.htm>