Change in osmo-bsc[master]: fix TCH/H allocation: use half occupied dyn TS instead of switching m...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Tue Nov 17 10:35:11 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/21203 )

Change subject: fix TCH/H allocation: use half occupied dyn TS instead of switching more dyn TS
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/21203/3/src/osmo-bsc/lchan_select.c 
File src/osmo-bsc/lchan_select.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/21203/3/src/osmo-bsc/lchan_select.c@119 
PS3, Line 119: 	for (allow_pchan_switch = 0; allow_pchan_switch <= (try_pchan_switch ? 1 : 0); allow_pchan_switch++) {
it would probably be clearer to use usual "i=0; i < n" loop notation here:
allow_pchan_switch < (try_pchan_switch ? 2 : 1)

Otherwise it looks a bit strange to i=0; i<=0; i++



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/21203
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5a8d943f31774af00664d037550be14e767d312a
Gerrit-Change-Number: 21203
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Tue, 17 Nov 2020 10:35:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201117/0dc32025/attachment.htm>


More information about the gerrit-log mailing list