Change in osmo-hlr[master]: USSD: fix handle_ussd(): do not free() unconditionally

[fixeria]

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/21182 )


Change subject: USSD: fix handle_ussd(): do not free() unconditionally
......................................................................

USSD: fix handle_ussd(): do not free() unconditionally

An internal handler may want to continue session, e.g. to request
more information from the MS, so we should check the session
state before calling ss_session_free().

Change-Id: I49262e7fe26f29dedbf126087cfb8f3bb3c548dc
---
M src/hlr_ussd.c
1 file changed, 3 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/82/21182/1

diff --git a/src/hlr_ussd.c b/src/hlr_ussd.c
index 25e9354..f7f8062 100644
--- a/src/hlr_ussd.c
+++ b/src/hlr_ussd.c
@@ -496,8 +496,9 @@
 		} else {
 			/* Handle internally */
 			ss->u.iuse->handle_ussd(ss, gsup, req);
-			/* Release session immediately */
-			ss_session_free(ss);
+			/* Release session if the handler has changed its state to END */
+			if (ss->state == OSMO_GSUP_SESSION_STATE_END)
+				ss_session_free(ss);
 		}
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/21182
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I49262e7fe26f29dedbf126087cfb8f3bb3c548dc
Gerrit-Change-Number: 21182
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201116/a9231e49/attachment.htm>