Change in osmo-ttcn3-hacks[master]: gbproxy: Less redundant component naming

[laforge]

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21176 )


Change subject: gbproxy: Less redundant component naming
......................................................................

gbproxy: Less redundant component naming

before this patch:
	GbProxy_Test-SGSN0-NS(SGSN)0-NSVCI101
after:
	GbProxy_Test-NS(SGSN[0])-NSVCI101

Change-Id: I8fc6b7526707206c147aa3c269c0204495e9f15a
---
M gbproxy/GBProxy_Tests.ttcn
1 file changed, 14 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/76/21176/1

diff --git a/gbproxy/GBProxy_Tests.ttcn b/gbproxy/GBProxy_Tests.ttcn
index f18216e..5d312f7 100644
--- a/gbproxy/GBProxy_Tests.ttcn
+++ b/gbproxy/GBProxy_Tests.ttcn
@@ -270,13 +270,15 @@
 };
 
 private function f_init_gb_pcu(inout GbInstance gb, charstring id, integer offset) runs on test_CT {
-	gb.vc_NS := NS_CT.create(id & "-NS(PCU)" & int2str(offset));
-	gb.vc_BSSGP := BSSGP_CT.create(id & "-BSSGP(PCU)" & int2str(offset));
+	var charstring ns_id := id & "-NS(PCU[" & int2str(offset) & "])";
+	var charstring bssgp_id := id & "-BSSGP(PCU[" & int2str(offset) & "])";
+	gb.vc_NS := NS_CT.create(ns_id);
+	gb.vc_BSSGP := BSSGP_CT.create(bssgp_id);
 	/* connect lower end of BSSGP emulation with NS upper port */
 	connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP);
 
-	gb.vc_NS.start(NSStart(mp_nsconfig_pcu[offset]));
-	gb.vc_BSSGP.start(BssgpStart(gb.cfg, id));
+	gb.vc_NS.start(NSStart(mp_nsconfig_pcu[offset], ns_id));
+	gb.vc_BSSGP.start(BssgpStart(gb.cfg, bssgp_id));
 
 	for (var integer i := 0; i < lengthof(gb.cfg.bvc); i := i + 1) {
 		connect(self:PROC, gb.vc_BSSGP:PROC);
@@ -286,13 +288,15 @@
 }
 
 private function f_init_gb_sgsn(inout GbInstance gb, charstring id, integer offset) runs on test_CT {
-	gb.vc_NS := NS_CT.create(id & "-NS(SGSN)" & int2str(offset));
-	gb.vc_BSSGP := BSSGP_CT.create(id & "-BSSGP(SGSN)" & int2str(offset));
+	var charstring ns_id := id & "-NS(SGSN[" & int2str(offset) & "])";
+	var charstring bssgp_id := id & "-BSSGP(SGSN[" & int2str(offset) & "])";
+	gb.vc_NS := NS_CT.create(ns_id);
+	gb.vc_BSSGP := BSSGP_CT.create(bssgp_id);
 	/* connect lower end of BSSGP emulation with NS upper port */
 	connect(gb.vc_BSSGP:BSCP, gb.vc_NS:NS_SP);
 
-	gb.vc_NS.start(NSStart(mp_nsconfig_sgsn[offset]));
-	gb.vc_BSSGP.start(BssgpStart(gb.cfg, id));
+	gb.vc_NS.start(NSStart(mp_nsconfig_sgsn[offset], ns_id));
+	gb.vc_BSSGP.start(BssgpStart(gb.cfg, bssgp_id));
 
 	for (var integer i := 0; i < lengthof(gb.cfg.bvc); i := i + 1) {
 		connect(self:PROC, gb.vc_BSSGP:PROC);
@@ -329,11 +333,11 @@
 
 	f_init_vty();
 	for (i := 0; i < lengthof(mp_nsconfig_sgsn); i := i+1) {
-		f_init_gb_sgsn(g_sgsn[0], "GbProxy_Test-SGSN" & int2str(i), 0);
+		f_init_gb_sgsn(g_sgsn[0], "GbProxy_Test", 0);
 	}
 	f_sleep(4.0);
 	for (i := 0; i < lengthof(mp_nsconfig_pcu); i := i+1) {
-		f_init_gb_pcu(g_pcu[i], "GbProxy_Test-PCU" & int2str(i), i);
+		f_init_gb_pcu(g_pcu[i], "GbProxy_Test", i);
 	}
 }
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21176
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8fc6b7526707206c147aa3c269c0204495e9f15a
Gerrit-Change-Number: 21176
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201116/e122c506/attachment.htm>