Change in osmo-ttcn3-hacks[master]: library/GSM_Types: add the Uplink flag to GsmBandArfcn

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 16 09:21:06 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21149 )

Change subject: library/GSM_Types: add the Uplink flag to GsmBandArfcn
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2: Code-Review+1
> > 
> > Not sure about the need for this or whether it makes sense to put the uplink/downlink flag inside.
> 
> This flag actually exists in GSMTAP header.  It's not like we really need it in ttcn3-bts-test, but I think it's good to have it for the sake of completeness.

But this is not GSMTAP, it's just describing arfcn/band information, and if there's no use for it I see no point in having it "for the sake of completeness". If it's needed for any reason then I'm with it, otherwise it only means another param to take care of.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21149
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bd7268b8a0fd8ed64064871c09fab35e15a761
Gerrit-Change-Number: 21149
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 16 Nov 2020 09:21:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201116/faf8d7a9/attachment.htm>


More information about the gerrit-log mailing list