This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21161 )
Change subject: Revert "tests: Fix tdef_test on 32bit platforms"
......................................................................
Revert "tests: Fix tdef_test on 32bit platforms"
This was not the issue, see next commit fixing the correct issue.
This reverts commit af10e48c1bf7ec40678b9a4387fc50ab0846b467.
Change-Id: Ifa1057ac55fcacdeb55ecdaac1ac3ddcca7d6d65
---
M tests/tdef/tdef_test.c
M tests/tdef/tdef_test.ok
2 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/tests/tdef/tdef_test.c b/tests/tdef/tdef_test.c
index 17fd4e5..d874231 100644
--- a/tests/tdef/tdef_test.c
+++ b/tests/tdef/tdef_test.c
@@ -48,7 +48,7 @@
/* test conversions */
{ .T=1000, .default_val=2*1000, .unit=OSMO_TDEF_MS, .desc="two seconds from ms" },
- { .T=1001, .default_val=30*1000, .unit=OSMO_TDEF_MS, .desc="half minute from ms" },
+ { .T=1001, .default_val=60*1000, .unit=OSMO_TDEF_MS, .desc="one minute from ms" },
{ .T=1004, .default_val=1, .unit=OSMO_TDEF_MS, .desc="one ms" },
{ .T=1005, .default_val=0, .unit=OSMO_TDEF_MS, .desc="zero ms" },
{ .T=1006, .default_val=0, .unit=OSMO_TDEF_S, .desc="zero s" },
diff --git a/tests/tdef/tdef_test.ok b/tests/tdef/tdef_test.ok
index 4bdd3d0..1770968 100644
--- a/tests/tdef/tdef_test.ok
+++ b/tests/tdef/tdef_test.ok
@@ -54,12 +54,12 @@
osmo_tdef_get(1000, m) = 1
osmo_tdef_get(1000, custom-unit) = 2000
osmo_tdef_get(1000, us) = 2000000
-T1001=30000ms
-osmo_tdef_get(1001, s) = 30
-osmo_tdef_get(1001, ms) = 30000
+T1001=60000ms
+osmo_tdef_get(1001, s) = 60
+osmo_tdef_get(1001, ms) = 60000
osmo_tdef_get(1001, m) = 1
-osmo_tdef_get(1001, custom-unit) = 30000
-osmo_tdef_get(1001, us) = 30000000
+osmo_tdef_get(1001, custom-unit) = 60000
+osmo_tdef_get(1001, us) = 60000000
T1004=1ms
osmo_tdef_get(1004, s) = 1
osmo_tdef_get(1004, ms) = 1
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21161
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifa1057ac55fcacdeb55ecdaac1ac3ddcca7d6d65
Gerrit-Change-Number: 21161
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201115/c921c4f0/attachment.htm>