Change in osmo-bts[master]: l1sap: add repeated downlink FACCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Sun Nov 15 20:31:06 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 )

Change subject: l1sap: add repeated downlink FACCH
......................................................................


Patch Set 6:

(2 comments)

This change is ready for review.

https://gerrit.osmocom.org/c/osmo-bts/+/21014/2/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21014/2/src/common/l1sap.c@925 
PS2, Line 925: fn + 8 <= fn
> As we all know, TDMA clock wraps around every 26 * 51 * 2048 frames. Imagine that msg. […]
oops! I almost forgot about the fn wrapping. I have now fixed it by wrapping the left side too.


https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/l1sap.c 
File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/l1sap.c@932 
PS5, Line 932: 2715648
> Indeed, I even mentioned them in my previous comments. This: […]
Done



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75
Gerrit-Change-Number: 21014
Gerrit-PatchSet: 6
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sun, 15 Nov 2020 20:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: dexter <pmaier at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201115/849d5077/attachment.htm>


More information about the gerrit-log mailing list