This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 )
Change subject: Configure E1 pcap file per line
......................................................................
Patch Set 5:
(3 comments)
https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/include/osmocom/abis/e1_input.h
File include/osmocom/abis/e1_input.h:
https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/include/osmocom/abis/e1_input.h@319
PS3, Line 319: int e1_set_pcap_fd(int fd, int e1_nr);
> OK, so I see this breaks osmo-nitb.. nothing else I have in my src tree calls it.
Yes a new function would be great to avoid breaking build in osmo-nitb.
BTW, what about padding a e1inp_line pointer instead of e1_nr?
1inp_set_pcap_fd(struct e1inp_line *line, int e1_nr);
https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c
File src/e1_input.c:
https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c@165
PS3, Line 165: llist_for_each_entry(line, &e1inp_line_list, list) {
pass line so that you don't need to do this here
https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c@186
PS3, Line 186: struct msgb *msg, int pcap_fd) {
> Um.. yes.., no? […]
Ah sorry I thought it's not because I didn't see any line added with it.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I316c3d6a839e84c2f52a148c6b8dd6f5933cf4bf
Gerrit-Change-Number: 21118
Gerrit-PatchSet: 5
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Fri, 13 Nov 2020 08:52:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201113/19fdaeea/attachment.htm>