This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 ) Change subject: Configure E1 pcap file per line ...................................................................... Patch Set 3: Code-Review-1 (7 comments) https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/include/osmocom/abis/e1_input.h File include/osmocom/abis/e1_input.h: https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/include/osmocom/abis/e1_input.h@224 PS3, Line 224: int pcap_fd; this needs to be initizalied to -1 somewhere. https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/include/osmocom/abis/e1_input.h@319 PS3, Line 319: int e1_set_pcap_fd(int fd, int e1_nr); this is breaking API, are we fine with it? Was this API already released? https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c File src/e1_input.c: https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c@186 PS3, Line 186: struct msgb *msg, int pcap_fd) { this pcap_fd is not used? https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input.c@901 PS3, Line 901: if (line->pcap_fd) >= 0 https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c File src/e1_input_vty.c: https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c@248 PS3, Line 248: DEFUN_ATTR(cfg_e1_pcap, cfg_e1_pcap_cmd, Rather update function names to be cfg_e1line_* https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c@266 PS3, Line 266: vty_out(vty, "Failed to setup E1 pcap recording to %s.%s", argv[1], VTY_NEWLINE); You can remove the dot at the end here and the string below. https://gerrit.osmocom.org/c/libosmo-abis/+/21118/3/src/e1_input_vty.c@279 PS3, Line 279: line->pcap_file = talloc_strdup(line, argv[1]); osmo_talloc_replace_string -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I316c3d6a839e84c2f52a148c6b8dd6f5933cf4bf Gerrit-Change-Number: 21118 Gerrit-PatchSet: 3 Gerrit-Owner: keith <keith at rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith at rhizomatica.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-CC: fixeria <vyanitskiy at sysmocom.de> Gerrit-CC: laforge <laforge at osmocom.org> Gerrit-Comment-Date: Thu, 12 Nov 2020 22:55:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201112/77e3e006/attachment.htm>