Change in osmo-ttcn3-hacks[master]: BSSGP_Emulation: Match on proper NSEI from NS layer

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 12 20:02:08 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21107 )

Change subject: BSSGP_Emulation: Match on proper NSEI from NS layer
......................................................................

BSSGP_Emulation: Match on proper NSEI from NS layer

Change-Id: I682574bc54b4432357adef2b4662b1f74495578c
---
M library/BSSGP_Emulation.ttcnpp
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp
index 87b35ac..a4a939d 100644
--- a/library/BSSGP_Emulation.ttcnpp
+++ b/library/BSSGP_Emulation.ttcnpp
@@ -359,7 +359,7 @@
 /* We are in BVC_S_WAIT_NS_ALIVE_UNBLOCKED (only happens in BSS role) */
 altstep as_sig_wait_ns_alive_unblocked() runs on BSSGP_CT {
 	var NsStatusIndication nsi;
-	[] BSCP.receive(NsStatusIndication:{?,?, complement (NSVC_S_ALIVE_UNBLOCKED), NSVC_S_ALIVE_UNBLOCKED}) -> value nsi {
+	[] BSCP.receive(NsStatusIndication:{g_cfg.nsei,?, complement (NSVC_S_ALIVE_UNBLOCKED), NSVC_S_ALIVE_UNBLOCKED}) -> value nsi {
 		/* if we just became NS-unblocked, send a BCC-RESET */
 		if (g_cfg.sgsn_role == false) {
 			BSCP.send(f_BnsUdReq(ts_BVC_RESET(BSSGP_CAUSE_OM_INTERVENTION, 0, omit), 0));
@@ -450,7 +450,11 @@
 		}
 	}
 	/* Keep NS Status Indicaitons to us; no need to inform per-BVC components [for now?] */
-	[] BSCP.receive(NsStatusIndication:?) -> value nsi { }
+	[] BSCP.receive(NsStatusIndication:{g_cfg.nsei, ?, ?, ?}) -> value nsi { }
+	/* We should never see any different NSEI: There's one BSSGP_CT per NSE */
+	[] BSCP.receive(NsStatusIndication:{?, ?, ?, ?}) -> value nsi {
+		setverdict(fail, "Rx NsStatusInd for wrong NSEI ", nsi);
+	}
 
 	/* Procedure port request to resolve the per-BVC component for a given ptp BVCI */
 	[] PROC.getcall(BSSGP_get_bvci_ct:{?}) -> param(bvci) sender vc_conn {

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21107
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I682574bc54b4432357adef2b4662b1f74495578c
Gerrit-Change-Number: 21107
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201112/58f4a157/attachment.htm>


More information about the gerrit-log mailing list