Change in libosmo-abis[master]: Include vty command 'pcap' in vty output

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 12 09:49:27 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/21118 )

Change subject: Include vty command 'pcap' in vty output
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/1/include/osmocom/abis/e1_input.h 
File include/osmocom/abis/e1_input.h:

https://gerrit.osmocom.org/c/libosmo-abis/+/21118/1/include/osmocom/abis/e1_input.h@197 
PS1, Line 197: 	char *pcap_file;
> I think it makes more sense to have a global pointer in e1_input_vty.c, just make it 'static'.
actually, the fact that we only have a single pcap file for potentially multiple lines is a problem.  Classic pcap files do not offer a way to annotate each packet with information on which interface it was received, so you cannot distinguish traffic from multiple lines.  Please create a separate osmocom redmine issue about this, we need to address this in a generic way.  Ideally generating pcap-ng with interface descriptions, or by moving pcap generation to "per line".  But even a single line can contain multiple TEI / datalinks, and you want ot somehow separate those....



-- 
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/21118
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I316c3d6a839e84c2f52a148c6b8dd6f5933cf4bf
Gerrit-Change-Number: 21118
Gerrit-PatchSet: 1
Gerrit-Owner: keith <keith at rhizomatica.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: keith <keith at rhizomatica.org>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 12 Nov 2020 09:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: keith <keith at rhizomatica.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201112/dcfa9af4/attachment.htm>


More information about the gerrit-log mailing list