This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20781 ) Change subject: Use osmo_fd_*_{disable,enable} ...................................................................... Use osmo_fd_*_{disable,enable} Change-Id: I16563a1033ad12a32104bfee974045ac4302bc74 Depends: libosmocore.git Idb89ba7bc7c129a6304a76900d17f47daf54d17d --- M TODO-RELEASE M src/osmobts_sock.cpp 2 files changed, 4 insertions(+), 3 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 17c6a34..40932ee 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,4 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line osmo-pcu update osmo-gsm-manuals dependency to > 0.3.0 for vty_cpu_sched.adoc include +osmo-pcu update libosmocore dependency > 1.4.x for osmo_fd_{read,write}_{enable,disable} diff --git a/src/osmobts_sock.cpp b/src/osmobts_sock.cpp index c9beff0..522581a 100644 --- a/src/osmobts_sock.cpp +++ b/src/osmobts_sock.cpp @@ -82,7 +82,7 @@ return -EIO; } msgb_enqueue(&pcu_sock_state.upqueue, msg); - conn_bfd->when |= OSMO_FD_WRITE; + osmo_fd_write_enable(conn_bfd); return 0; } @@ -153,7 +153,7 @@ msg = llist_entry(pcu_sock_state.upqueue.next, struct msgb, list); pcu_prim = (struct gsm_pcu_if *)msg->data; - bfd->when &= ~OSMO_FD_WRITE; + osmo_fd_write_disable(bfd); /* bug hunter 8-): maybe someone forgot msgb_put(...) ? */ if (!msgb_length(msg)) { @@ -168,7 +168,7 @@ goto close; if (rc < 0) { if (errno == EAGAIN) { - bfd->when |= OSMO_FD_WRITE; + osmo_fd_write_enable(bfd); break; } goto close; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20781 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I16563a1033ad12a32104bfee974045ac4302bc74 Gerrit-Change-Number: 20781 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201111/787c0ebe/attachment.htm>