Change in osmo-bts[master]: l1sap: add repeated downlink FACCH

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Wed Nov 11 20:06:39 UTC 2020


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/21014 )

Change subject: l1sap: add repeated downlink FACCH
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/vty.c 
File src/common/vty.c:

https://gerrit.osmocom.org/c/osmo-bts/+/21014/5/src/common/vty.c@805 
PS5, Line 805: 	   "facch-repetition",
why would we ant to have a configuration item for that in the BTS?  Shouldn't it be the policy of the BSC to simply not include the proprietary IE if SACCH repetiton is forbidden for administrative reasons?

In general, everything that can be configured in the BSC should be configured in the BSC, if they can be communicated over Abis.  And as we're adding that new IE anyway, I don't understand why we need a config here.

Every new configuration parameter we add (particularly in the "low level" parts of the network like BTS or PCU) is one parameter more than people are likely to forget about or set wrong.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/21014
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I72f0cf7eaaef9f80fc35e752c90ae0e2d24d0c75
Gerrit-Change-Number: 21014
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Wed, 11 Nov 2020 20:06:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201111/c5562a69/attachment.htm>


More information about the gerrit-log mailing list