Change in libosmocore[master]: gsm_04_08: add parser for Mobile Station Classmark 3

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Mon Nov 9 20:07:01 UTC 2020


dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/21083 )

Change subject: gsm_04_08: add parser for Mobile Station Classmark 3
......................................................................


Patch Set 3:

I tried to add some error checking now but I was not successful because of multiple reasons. The problem is how to detect the end of the bitstream. The input is octet aligned with padding bit at the end. So I can not just parse until the border of a release version and expect to get a -1 as return code when I parse one bit more (this would be the condition to detect the end).

Some of the CSN.1 fields have a restriction on the values (must be != 0x00). I have now removed those checks below release 4 (there is only one). Now everything that fullfills more than Release 4 should parse. There is no comment in the spec about earlier releases. I assume that CM3 got introduced with release 4. I would suggest to keep it like this. We do not need to overcomplicate this.


-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/21083
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic8b2bfd00330235f5bed00771e421588abfaac1f
Gerrit-Change-Number: 21083
Gerrit-PatchSet: 3
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Mon, 09 Nov 2020 20:07:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201109/6e5103e6/attachment.htm>


More information about the gerrit-log mailing list