Change in osmo-pcu[master]: tbf_ul: Allow non-egprs phones if EGPRS is enabled

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 9 11:21:31 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20993 )

Change subject: tbf_ul: Allow non-egprs phones if EGPRS is enabled
......................................................................

tbf_ul: Allow non-egprs phones if EGPRS is enabled

We'll be able to still serve GPRS-only phones if EGPRS is enabled.

Related: OS#4544
Change-Id: I2e01b9d0de7506e0c0960342d73dba29187fe61f
---
M src/bts.h
M src/tbf_ul.cpp
2 files changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved



diff --git a/src/bts.h b/src/bts.h
index 8d7f6ca..6a2d3b0 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -191,7 +191,6 @@
 	CTR_TBF_REUSED,
 	CTR_TBF_ALLOC_ALGO_A,
 	CTR_TBF_ALLOC_ALGO_B,
-	CTR_TBF_FAILED_EGPRS_ONLY,
 	CTR_RLC_SENT,
 	CTR_RLC_RESENT,
 	CTR_RLC_RESTARTED,
diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index 4d8588c..c594c59 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -103,12 +103,6 @@
 
 	OSMO_ASSERT(ms != NULL);
 
-	if (ms->egprs_ms_class() == 0 && bts->egprs_enabled) {
-		LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone in EGPRS-only mode\n");
-		bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY);
-		return NULL;
-	}
-
 	LOGP(DTBF, LOGL_DEBUG, "********** UL-TBF starts here **********\n");
 	LOGP(DTBF, LOGL_INFO, "Allocating UL TBF: MS_CLASS=%d/%d\n",
 	     ms->ms_class(), ms->egprs_ms_class());

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20993
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2e01b9d0de7506e0c0960342d73dba29187fe61f
Gerrit-Change-Number: 20993
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201109/830ce0c5/attachment.htm>


More information about the gerrit-log mailing list