Change in osmo-ttcn3-hacks[master]: pcu: Implement check for expected (M)CS in received data block

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21034 )

Change subject: pcu: Implement check for expected (M)CS in received data block
......................................................................

pcu: Implement check for expected (M)CS in received data block

Change-Id: Ibdc63f6b695c08e4ddf5894c22767d07acf21311
---
M pcu/GPRS_Components.ttcn
1 file changed, 8 insertions(+), 3 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve



diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn
index f9697a1..234d910 100644
--- a/pcu/GPRS_Components.ttcn
+++ b/pcu/GPRS_Components.ttcn
@@ -902,7 +902,10 @@
 		f_shutdown(__BFILE__, __LINE__);
 	}
 
-	/* TODO: check exp_cs */
+	if (not match(data_block.cs, exp_cs)) {
+		setverdict(fail, "Failed to match ", data_block.cs, " vs exp ", exp_cs);
+		f_shutdown(__BFILE__, __LINE__);
+	}
 }
 
 /* This function does what could probably be done with templates */
@@ -934,8 +937,10 @@
 		f_shutdown(__BFILE__, __LINE__);
 	}
 
-	/* TODO: Check exp_cs. In the case of EGPRS, first check mac_hdr.header_type and then decode CPS = exp_cs based on mac_hdr.header_type.
-		See wireshark's egprs_Header_type1_coding_puncturing_scheme_to_mcs. */
+	if (not match(data_block.mcs, exp_cs)) {
+		setverdict(fail, "Failed to match ", data_block.mcs, " vs exp ", exp_cs);
+		f_shutdown(__BFILE__, __LINE__);
+	}
 }
 
 /* High level (task specific) helper for receiving and matching GPRS/EGPRS data blocks */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21034
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ibdc63f6b695c08e4ddf5894c22767d07acf21311
Gerrit-Change-Number: 21034
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201109/b16556c3/attachment.htm>