Change in osmo-ccid-firmware[master]: 7816 fsm: move to static msgb

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Sat Nov 7 18:43:14 UTC 2020


Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/21071 )

Change subject: 7816 fsm: move to static msgb
......................................................................

7816 fsm: move to static msgb

Error handling was difficult due to the need to pass msgb pointers
attached to the sub fsms back to the cb that is polled from the main
loop to be able free them, while ensuring they never get lost, because
memory leakage is deadly.

This is now fixed by using static pseudo-msgbs for the fsms that are
never deallocated. This only adds one tpdu tx copy, the ccid response
msgbs were already being copied anyway, so memory usage has not changed
except for the "unused slots" case that is not really important since
the octsim was designed around concurrent slot operation anway.

All of this allows convenient error handling in the allstate function
instead of having to spread it all over the sub fsms - in practice
handling errors mostly consists of card deactivation + returning a
proper failure message that matches the ccid command anyway.

Change-Id: I65e77c376aca9ed50e234a0b58a7450a8bbd4fe0
---
M ccid_common/ccid_slot_fsm.c
M ccid_common/iso7816_fsm.c
M ccid_common/iso7816_fsm.h
3 files changed, 216 insertions(+), 151 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/71/21071/2
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/21071
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I65e77c376aca9ed50e234a0b58a7450a8bbd4fe0
Gerrit-Change-Number: 21071
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201107/32ddaa23/attachment.htm>


More information about the gerrit-log mailing list