Change in osmo-gsm-tester[master]: iperf3: don't throw exception when parsing iperf Json fails

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

srs_andre gerrit-no-reply at lists.osmocom.org
Fri Nov 6 12:05:57 UTC 2020


srs_andre has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21056 )


Change subject: iperf3: don't throw exception when parsing iperf Json fails
......................................................................

iperf3: don't throw exception when parsing iperf Json fails

test crashed when iperf didn't produce valid json output.
since this isn't criticial in most cases, lets convert this
into a log rather than a exception

05:42:23.089740 run           iperf3-srv_192.168.4.1: failed parsing iperf3 output: "(launched: 2020-10-26_05:41:16.432261)
"
05:42:23.092642 tst                  iperf3_ul.py:37: ERR: IndexError: list index out of range  [trial-196↪4g_whitelist:amarisoftenb-rftype at zmq+srsue-rftype@zmq+mod-enb-nprb at 50+mod-enb-cells-2ca+cfg-epc-type@amarisoftepc+cfg-epc-qci at 8+cfg-srs-enable-pcap+cfg-log@info↪iperf3_ul.py:37]

Change-Id: I14a17bf1f239fc7765c2272109dbdda5e8e08d79
---
M src/osmo_gsm_tester/obj/iperf3.py
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/56/21056/1

diff --git a/src/osmo_gsm_tester/obj/iperf3.py b/src/osmo_gsm_tester/obj/iperf3.py
index 2039a9b..4785f78 100644
--- a/src/osmo_gsm_tester/obj/iperf3.py
+++ b/src/osmo_gsm_tester/obj/iperf3.py
@@ -48,7 +48,7 @@
         return j
     except Exception as e:
         log_obj.log('failed parsing iperf3 output: "%s"' % data)
-        raise e
+        pass
 
 def print_result_node_udp(result, node_str):
     try:
@@ -57,7 +57,7 @@
         print("\tSUM: %d KB, %d kbps, %d seconds %d/%d lost" % (sum['bytes']/1000, sum['bits_per_second']/1000, sum['seconds'], sum['lost_packets'], sum['packets']))
     except Exception as e:
         print("Exception while using iperf3 %s results: %r" % (node_str, repr(result)))
-        raise e
+        pass
 
 def print_result_node_tcp(result, node_str):
     try:
@@ -68,7 +68,7 @@
         print("\tRECV: %d KB, %d kbps, %d seconds" % (recv['bytes']/1000, recv['bits_per_second']/1000, recv['seconds']))
     except Exception as e:
         print("Exception while using iperf3 %s results: %r" % (node_str, repr(result)))
-        raise e
+        pass
 
 def get_received_mbps(result, isUdp=True):
     try:
@@ -76,7 +76,7 @@
         return recv['bits_per_second']/1e6
     except Exception as e:
         print("Exception while using iperf3 results: %r" % (repr(result)))
-        raise e
+        pass
 
 class IPerf3Server(log.Origin):
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/21056
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I14a17bf1f239fc7765c2272109dbdda5e8e08d79
Gerrit-Change-Number: 21056
Gerrit-PatchSet: 1
Gerrit-Owner: srs_andre <andre at softwareradiosystems.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201106/efd9c476/attachment.htm>


More information about the gerrit-log mailing list