Change in osmo-pcu[master]: tbf_dl: Don't fake EGPRS MS class when no related info is available

[laforge]

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20936 )

Change subject: tbf_dl: Don't fake EGPRS MS class when no related info is available
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp 
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp@a134 
PS3, Line 134: LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone in EGPRS-only mode\n");
             : 			bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY);
             : 			return NULL;
> "The moment" is not yet there, but we are simply missing the part where we downgrade a DL msg to MCS […]
I really disagree here. Having a clean "EGPRS only works" vs "GPRS only works" situation is good.  Having a "EGPRS only" configuration where GPRS only handets fail in weird and strange ways depending on what else is happening on the cell is not an improvement in my eyes.  Maybe I'm not understanding it?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20936
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icce66cadb51af25ae0c3b3719940eccb548fe33b
Gerrit-Change-Number: 20936
Gerrit-PatchSet: 6
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Thu, 05 Nov 2020 22:50:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201105/2de9e4c3/attachment.htm>