Change in osmo-pcu[master]: Get rid of bts->egprs_enabled

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu Nov 5 14:41:34 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20994 )

Change subject: Get rid of bts->egprs_enabled
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20994/4/src/gprs_bssgp_pcu.cpp 
File src/gprs_bssgp_pcu.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/20994/4/src/gprs_bssgp_pcu.cpp@748 
PS4, Line 748: 			num = i + 1;
> just to make sure that i + 1 is intentional, vs num++ […]
it's intentional, it's the CS<num>. so CS<num> is known by num-1 shifted bits in the mask:
CS1 -> 1 << 0
CS4 -> 1 << 3

I first implemented it as an array of bools but then I was requested to move it into a bitmask, so here we are :)



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20994
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ifcf23771bd23afc64ca6fea38948f98f2d134ecb
Gerrit-Change-Number: 20994
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Comment-Date: Thu, 05 Nov 2020 14:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201105/b1acf0d1/attachment.htm>


More information about the gerrit-log mailing list