Change in osmo-pcu[master]: gprs_ms: Avoid enabling EGPRS if no MCS are supported

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 4 17:35:00 UTC 2020


pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21046 )


Change subject: gprs_ms: Avoid enabling EGPRS if no MCS are supported
......................................................................

gprs_ms: Avoid enabling EGPRS if no MCS are supported

This patch avoids enabling EGPRS on MS objects if BTS/VTY assigned no
MCS supported/available for use.
As a result, if NO MCS is enabled/supported EGPRS won't be used despite
the MS announcing through EGPRS MS class that it supports EGPRS.

Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3
---
M src/gprs_ms.cpp
M src/tbf.cpp
2 files changed, 8 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/46/21046/1

diff --git a/src/gprs_ms.cpp b/src/gprs_ms.cpp
index b295686..8eb23d9 100644
--- a/src/gprs_ms.cpp
+++ b/src/gprs_ms.cpp
@@ -541,6 +541,13 @@
 
 	m_egprs_ms_class = ms_class_;
 
+	if (!m_bts->max_mcs_ul() || !m_bts->max_mcs_dl()) {
+		LOGPMS(this, DRLCMAC, LOGL_DEBUG,
+		       "Avoid enabling EGPRS because use of MCS is disabled: ul=%u dl=%u\n",
+			m_bts->max_mcs_ul(), m_bts->max_mcs_dl());
+		return;
+	}
+
 	if (mcs_is_edge_gmsk(mcs_get_egprs_by_num(m_bts->max_mcs_ul())) &&
 		mcs_is_edge_gmsk(mcs_get_egprs_by_num(m_bts->max_mcs_dl())) &&
 		mode() != EGPRS)
diff --git a/src/tbf.cpp b/src/tbf.cpp
index 4f685e8..2371aed 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -745,7 +745,7 @@
 	struct gprs_rlcmac_bts *bts_data = bts->bts_data();
 	int rc;
 
-	if (m_ms->egprs_ms_class() > 0)
+	if (m_ms->mode() != GPRS)
 		enable_egprs();
 
 	m_created_ts = time(NULL);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21046
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ib19e9e006d851c2147de15f4aec36ab65250bdd3
Gerrit-Change-Number: 21046
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201104/d782e8da/attachment.htm>


More information about the gerrit-log mailing list