Change in osmo-pcu[master]: Move BTS initial values inside bts.cpp

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 4 11:43:31 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/21020 )

Change subject: Move BTS initial values inside bts.cpp
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp 
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/src/bts.cpp@327 
PS1, Line 327: bts_init
> Does it really make sense to have everything in a separate function? I would keep/move everything he […]
It's different object/struct so yes, to me it makes sense having it separate.


https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/ms/MsTest.ok 
File tests/ms/MsTest.ok:

https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/ms/MsTest.ok@a22 
PS1, Line 22: UNKNOWN/UNKNOWN, UL UNKNOWN/UNKNOWN
> LOL, the author of this unit test didn't seem to care about the expectations...
I pointed that out already, but given the previous state when the tests we added I can understand it's was impossible to add this amount of code path coverage and fixing all issues at the same time, so I can understand the current situation.


https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp 
File tests/tbf/TbfTest.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/21020/1/tests/tbf/TbfTest.cpp@a799 
PS1, Line 799: 03
> In any case, would be nice if you document this positive side-effect in the commit message. […]
I think it can be seen already when seeing the patch (unit test output results) and in here in the gerrit discussion.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/21020
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iffd6eecb1f08bda0091f45e2ef7c9c63b42e10b3
Gerrit-Change-Number: 21020
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis at fe80.eu>
Gerrit-Comment-Date: Wed, 04 Nov 2020 11:43:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de>
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis at fe80.eu>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201104/c2ae26f5/attachment.htm>


More information about the gerrit-log mailing list