This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
daniel gerrit-no-reply at lists.osmocom.orgdaniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/20957 ) Change subject: Add exported function btsctx_alloc to public header ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/20957/1/include/osmocom/gprs/gprs_bssgp.h File include/osmocom/gprs/gprs_bssgp.h: https://gerrit.osmocom.org/c/libosmocore/+/20957/1/include/osmocom/gprs/gprs_bssgp.h@115 PS1, Line 115: struct bssgp_bvc_ctx *btsctx_alloc(uint16_t bvci, uint16_t nsei); > Is it needed or can just be moved to be static? The symbol is exported in libosmogb.map so it can't be static >From commit fcaa80553ebedf88184bfab981ecfe754c7e1c4e (2012): libosmogb: export btsctx_* functions Those should be private, but osmo-pcu currently needs them... Additionally it's still used in src/gprs_bssgp_pcu.cpp and osmo-gbproxy needs it. The pcu has its own declaration but if we export the symbol we might as well have the function in the public header -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20957 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iddfb8e42d5d9e856c7165d3cff6c39191c86a4a5 Gerrit-Change-Number: 20957 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 03 Nov 2020 08:48:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201103/91ed5b79/attachment.htm>