Change in osmo-pcu[master]: tbf_dl: Don't fake EGPRS MS class when no related info is available

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Mon Nov 2 15:11:49 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/20936 )

Change subject: tbf_dl: Don't fake EGPRS MS class when no related info is available
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp 
File src/tbf_dl.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/20936/3/src/tbf_dl.cpp@a134 
PS3, Line 134: LOGP(DTBF, LOGL_NOTICE, "Not accepting non-EGPRS phone in EGPRS-only mode\n");
             : 			bts->bts->do_rate_ctr_inc(CTR_TBF_FAILED_EGPRS_ONLY);
             : 			return NULL;
> i think this error message and the rate counter are still applicable. […]
Because this constraint in this code path makes no sense at the moment we support both EGPRS and GPRS MS, we simply allocated GPRS/EGPRS TBF based on MS class support.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/20936
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icce66cadb51af25ae0c3b3719940eccb548fe33b
Gerrit-Change-Number: 20936
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-CC: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Mon, 02 Nov 2020 15:11:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge at osmocom.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/c767eba0/attachment.htm>


More information about the gerrit-log mailing list