Change in osmo-ttcn3-hacks[master]: BTS_Tests/DTX: remove redundant RSL channel number check

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Mon Nov 2 09:31:47 UTC 2020


laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20889 )

Change subject: BTS_Tests/DTX: remove redundant RSL channel number check
......................................................................

BTS_Tests/DTX: remove redundant RSL channel number check

We never launch this test case in DTX mode on anything else than
TCH/F, so it does not make sense to check this all the time.

Change-Id: I6e971d87f26253f4283c47b7f8826d14a2567a9b
Related: OS#4801
---
M bts/BTS_Tests.ttcn
1 file changed, 0 insertions(+), 6 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 1a659a2..735a36a 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -6743,12 +6743,6 @@
 		}
 
 		if (dtxd) {
-			if (not match(g_chan_nr, t_RslChanNr_Bm(?))) {
-				T.stop;
-				f_rsl_chan_deact();
-				f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr);
-				Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Received fill frame on non-TCH/F channel; DTX is only allowed on TCH/F!");
-			}
 			if (fn > first_fn + frame_dtx_tchf_mod) {
 				T.stop;
 				f_rsl_chan_deact();

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/20889
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6e971d87f26253f4283c47b7f8826d14a2567a9b
Gerrit-Change-Number: 20889
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/05ac95bf/attachment.htm>


More information about the gerrit-log mailing list