Change in osmo-ttcn3-hacks[master]: PCU_Tests: add 'f_multi_ms_' API for multi-MS test cases

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Mon Nov 2 04:36:23 UTC 2020


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21008 )

Change subject: PCU_Tests: add 'f_multi_ms_' API for multi-MS test cases
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21008/1/pcu/PCU_Tests.ttcn 
File pcu/PCU_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21008/1/pcu/PCU_Tests.ttcn@241 
PS1, Line 241: /* Register TLLI of each allocated GprsMS instance */
> I don't really see a need for this APIs so far, I wouldn't merge this, I think is fine keeping this  […]
You mean f_multi_ms_bssgp_register()? Or f_multi_ms_establish_tbf() too?

I believe it's good to have more multi-MS test cases, and I don't see why we shouldn't merge this API. Back then it was you who introduced f_init_gprs_ms() that kind of allowed to have multiple MS, and now you're against multi-MS API? ;)


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21008/1/pcu/PCU_Tests.ttcn@245 
PS1, Line 245: FFFFFFFF
I should have used TLLI_UNUSED.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/21008
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie2cc717f9f50db16748fe4e4a0ad80d549981e61
Gerrit-Change-Number: 21008
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Nov 2020 04:36:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20201102/fb49e0a9/attachment.htm>


More information about the gerrit-log mailing list