Change in docker-playground[master]: osmo-*-master: support centos8

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

osmith gerrit-no-reply at lists.osmocom.org
Sat May 30 09:37:37 UTC 2020


osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/18554 )

Change subject: osmo-*-master: support centos8
......................................................................

osmo-*-master: support centos8

Adjust the Dockerfiles, so 'docker_images_require osmo-mgw-master-centos8'
etc. result in a centos8 based image. centos8-build already configures the
Osmocom nightly repository, so we only need to configure it for
debian-stretch.

Related: OS#4564
Change-Id: I6579748056ce0505304378b342a698b98c77fd18
---
M osmo-bsc-master/Dockerfile
M osmo-bts-master/Dockerfile
M osmo-ggsn-master/Dockerfile
M osmo-hlr-master/Dockerfile
M osmo-mgw-master/Dockerfile
M osmo-msc-master/Dockerfile
M osmo-pcu-master/Dockerfile
M osmo-remsim-master/Dockerfile
M osmo-sgsn-master/Dockerfile
M osmo-sip-master/Dockerfile
M osmo-stp-master/Dockerfile
11 files changed, 421 insertions(+), 163 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  osmith: Looks good to me, approved; Verified



diff --git a/osmo-bsc-master/Dockerfile b/osmo-bsc-master/Dockerfile
index 75afbb7..57b4b04 100644
--- a/osmo-bsc-master/Dockerfile
+++ b/osmo-bsc-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,22 +10,43 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev \
-		libosmo-abis-dev \
-		libosmo-netif-dev \
-		libosmo-sccp-dev \
-		libosmo-sigtran-dev \
-		libosmo-mgcp-client-dev \
-		libgtp-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev \
+			libosmo-abis-dev \
+			libosmo-netif-dev \
+			libosmo-sccp-dev \
+			libosmo-sigtran-dev \
+			libosmo-mgcp-client-dev \
+			libgtp-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			"pkgconfig(libosmo-mgcp-client)" \
+			"pkgconfig(libosmo-netif)" \
+			"pkgconfig(libosmo-sccp)" \
+			"pkgconfig(libosmo-sigtran)" \
+			"pkgconfig(libosmoabis)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmoctrl)" \
+			"pkgconfig(libosmogb)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+		;; \
+	esac
 
 WORKDIR	/tmp
 
diff --git a/osmo-bts-master/Dockerfile b/osmo-bts-master/Dockerfile
index b73f2ac..98b0bb0 100644
--- a/osmo-bts-master/Dockerfile
+++ b/osmo-bts-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,21 +10,42 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev \
-		libosmo-abis-dev \
-		libosmo-netif-dev \
-		libosmo-sccp-dev \
-		libsmpp34-dev \
-		libgtp-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev \
+			libosmo-abis-dev \
+			libosmo-netif-dev \
+			libosmo-sccp-dev \
+			libsmpp34-dev \
+			libgtp-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			"pkgconfig(libosmoabis)" \
+			"pkgconfig(libosmocodec)" \
+			"pkgconfig(libosmocoding)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmoctrl)" \
+			"pkgconfig(libosmogb)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmotrau)" \
+			"pkgconfig(libosmovty)" \
+			telnet \
+		;; \
+	esac
 
 ADD	respawn.sh /usr/local/bin/respawn.sh
 
diff --git a/osmo-ggsn-master/Dockerfile b/osmo-ggsn-master/Dockerfile
index 3802670..81444d8 100644
--- a/osmo-ggsn-master/Dockerfile
+++ b/osmo-ggsn-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,16 +10,33 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			telnet \
+			"pkgconfig(libgtpnl)" \
+			"pkgconfig(libmnl)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmoctrl)" \
+			"pkgconfig(libosmovty)" \
+		;; \
+	esac
 
 WORKDIR	/tmp
 
diff --git a/osmo-hlr-master/Dockerfile b/osmo-hlr-master/Dockerfile
index 3aa8468..d4727cc 100644
--- a/osmo-hlr-master/Dockerfile
+++ b/osmo-hlr-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,20 +10,38 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		libdbd-sqlite3 \
-		libosmo-abis-dev \
-		libosmo-netif-dev \
-		libosmo-sigtran-dev \
-		libosmocore-dev \
-		telnet && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			libdbd-sqlite3 \
+			libosmo-abis-dev \
+			libosmo-netif-dev \
+			libosmo-sigtran-dev \
+			libosmocore-dev \
+			telnet && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			"pkgconfig(libosmoabis)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmoctrl)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+			python3 \
+			telnet \
+		;; \
+	esac
 
 WORKDIR	/tmp
 
diff --git a/osmo-mgw-master/Dockerfile b/osmo-mgw-master/Dockerfile
index f898c7e..773c2a5 100644
--- a/osmo-mgw-master/Dockerfile
+++ b/osmo-mgw-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,19 +10,37 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev \
-		libosmo-abis-dev \
-		libosmo-netif-dev \
-		libosmo-sccp-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev \
+			libosmo-abis-dev \
+			libosmo-netif-dev \
+			libosmo-sccp-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			telnet \
+			"pkgconfig(libosmo-netif)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmoctrl)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+			"pkgconfig(libosmocoding)" \
+		;; \
+	esac
 
 WORKDIR	/tmp
 
diff --git a/osmo-msc-master/Dockerfile b/osmo-msc-master/Dockerfile
index 55e5d6e..366e77c 100644
--- a/osmo-msc-master/Dockerfile
+++ b/osmo-msc-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,27 +10,52 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		libasn1c-dev \
-		libdbd-sqlite3 \
-		libdbi-dev \
-		libosmo-abis-dev \
-		libosmo-mgcp-client-dev \
-		libosmo-gsup-client-dev \
-		libosmo-netif-dev \
-		libosmo-ranap-dev \
-		libosmo-sccp-dev \
-		libosmo-sigtran-dev \
-		libosmocore-dev \
-		libsmpp34-dev \
-		telnet && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			libasn1c-dev \
+			libdbd-sqlite3 \
+			libdbi-dev \
+			libosmo-abis-dev \
+			libosmo-mgcp-client-dev \
+			libosmo-gsup-client-dev \
+			libosmo-netif-dev \
+			libosmo-ranap-dev \
+			libosmo-sccp-dev \
+			libosmo-sigtran-dev \
+			libosmocore-dev \
+			libsmpp34-dev \
+			telnet && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			telnet \
+			"pkgconfig(libasn1c)" \
+			"pkgconfig(libosmo-gsup-client)" \
+			"pkgconfig(libosmo-mgcp-client)" \
+			"pkgconfig(libosmo-netif)" \
+			"pkgconfig(libosmo-ranap)" \
+			"pkgconfig(libosmo-sccp)" \
+			"pkgconfig(libosmo-sigtran)" \
+			"pkgconfig(libosmoabis)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmoctrl)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+			"pkgconfig(libsmpp34)" \
+		;; \
+	esac
 
 WORKDIR	/tmp
 
diff --git a/osmo-pcu-master/Dockerfile b/osmo-pcu-master/Dockerfile
index 1aed8c9..e8ce5d8 100644
--- a/osmo-pcu-master/Dockerfile
+++ b/osmo-pcu-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,16 +10,32 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			telnet \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmogb)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+		;; \
+	esac
 
 ADD	respawn.sh /usr/local/bin/respawn.sh
 
diff --git a/osmo-remsim-master/Dockerfile b/osmo-remsim-master/Dockerfile
index 0a15d93..bed7f47 100644
--- a/osmo-remsim-master/Dockerfile
+++ b/osmo-remsim-master/Dockerfile
@@ -1,17 +1,30 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
 # PC/SC required for testing of bankd (with vpcd)
 # autoconf, automake, libtool, pkg-config, m4, help2man required for virtualsmartcard
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		libpcsclite-dev \
-		pcscd \
-		pcsc-tools \
-		autoconf automake libtool pkg-config m4 help2man ca-certificates && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			libpcsclite-dev \
+			pcscd \
+			pcsc-tools \
+			autoconf automake libtool pkg-config m4 help2man ca-certificates && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			pcsc-lite \
+			help2man \
+			python3 \
+		;; \
+	esac
 
 # build virtualsmartcard
 RUN	git clone https://github.com/frankmorgner/vsmartcard.git
@@ -22,24 +35,46 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev \
-		libosmo-simtrace2-dev \
-		libosmo-abis-dev \
-		libosmo-netif-dev \
-		libpcsclite-dev \
-		libcsv-dev \
-		libjansson-dev \
-		libulfius-dev \
-		liborcania-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev \
+			libosmo-simtrace2-dev \
+			libosmo-abis-dev \
+			libosmo-netif-dev \
+			libpcsclite-dev \
+			libcsv-dev \
+			libjansson-dev \
+			libulfius-dev \
+			liborcania-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			telnet \
+			"pkgconfig(libasn1c)" \
+			"pkgconfig(libosmoabis)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmosim)" \
+			"pkgconfig(libpcsclite)" \
+			"pkgconfig(libulfius)" \
+			"pkgconfig(libusb-1.0)" \
+			"pkgconfig(libosmousb)" \
+			"pkgconfig(libosmo-simtrace2)" \
+		;; \
+	esac
 
 #ADD	respawn.sh /usr/local/bin/respawn.sh
 
diff --git a/osmo-sgsn-master/Dockerfile b/osmo-sgsn-master/Dockerfile
index 10fc92e..1121712 100644
--- a/osmo-sgsn-master/Dockerfile
+++ b/osmo-sgsn-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,25 +10,50 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev \
-		libosmo-abis-dev \
-		libosmo-gsup-client-dev \
-		libosmo-netif-dev \
-		libosmo-ranap-dev \
-		libosmo-sccp-dev \
-		libosmo-sigtran-dev \
-		libsmpp34-dev \
-		libgtp-dev \
-		libasn1c-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev \
+			libosmo-abis-dev \
+			libosmo-gsup-client-dev \
+			libosmo-netif-dev \
+			libosmo-ranap-dev \
+			libosmo-sccp-dev \
+			libosmo-sigtran-dev \
+			libsmpp34-dev \
+			libgtp-dev \
+			libasn1c-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			telnet \
+			"pkgconfig(libasn1c)" \
+			"pkgconfig(libcrypto)" \
+			"pkgconfig(libgtp)" \
+			"pkgconfig(libosmo-gsup-client)" \
+			"pkgconfig(libosmo-netif)" \
+			"pkgconfig(libosmo-ranap)" \
+			"pkgconfig(libosmo-sigtran)" \
+			"pkgconfig(libosmoabis)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmoctrl)" \
+			"pkgconfig(libosmogb)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+			;; \
+	esac
 
 WORKDIR	/tmp
 
diff --git a/osmo-sip-master/Dockerfile b/osmo-sip-master/Dockerfile
index 2407984..b15a2c9 100644
--- a/osmo-sip-master/Dockerfile
+++ b/osmo-sip-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,26 +10,42 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		libasn1c-dev \
-		libdbd-sqlite3 \
-		libdbi-dev \
-		libosmo-abis-dev \
-		libosmo-mgcp-client-dev \
-		libosmo-netif-dev \
-		libosmo-ranap-dev \
-		libosmo-sccp-dev \
-		libosmo-sigtran-dev \
-		libosmocore-dev \
-		libsmpp34-dev \
-		telnet && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			libasn1c-dev \
+			libdbd-sqlite3 \
+			libdbi-dev \
+			libosmo-abis-dev \
+			libosmo-mgcp-client-dev \
+			libosmo-netif-dev \
+			libosmo-ranap-dev \
+			libosmo-sccp-dev \
+			libosmo-sigtran-dev \
+			libosmocore-dev \
+			libsmpp34-dev \
+			telnet && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+			"pkgconfig(sofia-sip-ua-glib)" \
+			telnet \
+		;; \
+	esac
 
 WORKDIR	/tmp
 
diff --git a/osmo-stp-master/Dockerfile b/osmo-stp-master/Dockerfile
index 62bcbc7..a91313f 100644
--- a/osmo-stp-master/Dockerfile
+++ b/osmo-stp-master/Dockerfile
@@ -1,5 +1,8 @@
 ARG	USER
-FROM	$USER/debian-stretch-build
+ARG	DISTRO
+FROM	$USER/$DISTRO-build
+# Arguments used after FROM must be specified again
+ARG	DISTRO
 
 MAINTAINER Harald Welte <laforge at gnumonks.org>
 
@@ -7,17 +10,33 @@
 
 COPY	Release.key /tmp/Release.key
 
-RUN	apt-key add /tmp/Release.key && \
-	rm /tmp/Release.key && \
-	echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-key add /tmp/Release.key && \
+		rm /tmp/Release.key && \
+		echo "deb " $OSMOCOM_REPO " ./" > /etc/apt/sources.list.d/osmocom-nightly.list \
+		;; \
+	esac
 
 ADD	$OSMOCOM_REPO/Release /tmp/Release
-RUN	apt-get update && \
-	apt-get install -y --no-install-recommends \
-		telnet \
-		libosmocore-dev \
-		libosmo-netif-dev && \
-	apt-get clean
+RUN	case "$DISTRO" in \
+	debian*) \
+		apt-get update && \
+		apt-get install -y --no-install-recommends \
+			telnet \
+			libosmocore-dev \
+			libosmo-netif-dev && \
+		apt-get clean \
+		;; \
+	centos*) \
+		dnf install -y \
+			telnet \
+			"pkgconfig(libosmo-netif)" \
+			"pkgconfig(libosmocore)" \
+			"pkgconfig(libosmogsm)" \
+			"pkgconfig(libosmovty)" \
+		;; \
+	esac
 
 WORKDIR	/tmp
 

-- 
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/18554
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I6579748056ce0505304378b342a698b98c77fd18
Gerrit-Change-Number: 18554
Gerrit-PatchSet: 6
Gerrit-Owner: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: fixeria <axilirator at gmail.com>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: osmith <osmith at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200530/35bc23d2/attachment.htm>


More information about the gerrit-log mailing list