Change in osmo-sgsn[master]: gbproxy_test.c: fix mobile identity test data

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri May 29 20:41:31 UTC 2020


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/18585 )

Change subject: gbproxy_test.c: fix mobile identity test data
......................................................................


Patch Set 2:

> Patch Set 2:
> 
> > Patch Set 2:
> > 
> > So it may be helpful to keep the old wrong MI to verify that osmo-sgsn acts consistently when that is received?
> 
> The aim is what, do you mean an invalid IMSI like this should still be accepted by osmo-programs?

I don't know what should be the consequence, didn't look in detail at the issue, but given the chance we have some hexstring already in there with bad MI, it may make sense to have that in a unit test to see how gbpoprxy behaves.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/18585
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: Ia006a3da6779ad1984f642e8ea29790a4daeb8b9
Gerrit-Change-Number: 18585
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-CC: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 29 May 2020 20:41:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/28346b85/attachment.htm>


More information about the gerrit-log mailing list