This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
neels gerrit-no-reply at lists.osmocom.orgneels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18504 ) Change subject: create only one SCCP user per SCCP instance ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18504/3/src/osmo-bsc/osmo_bsc_sigtran.c File src/osmo-bsc/osmo_bsc_sigtran.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18504/3/src/osmo-bsc/osmo_bsc_sigtran.c@550 PS3, Line 550: /* Bind SCCP user. Bind only one user per sccp_instance. */ > Can you describe a bit better (in gerrit is fine) the situation here? So how can it happen than duri […] I'm implementing MSC pooling, i.e. there are multiple A links to MSCs. Each MSC could technically be connected by a separate cs7 instance, but this patch is for the scenario where osmo-bsc has a single cs7 instance to connect to all of the MSCs in the pool (exactly how osmo-msc typically connects to multiple BSCs). So, the scenario is: osmo-bsc.cfg has 'msc 0', 'msc 1', 'msc 2', each with a different remote PC to reach a different MSC, but just one local PC for all of them. When 'msc 0' is set up, we do the "simple client" thing and establish AS and ASP, and also add an SCCP User with osmo-bsc's local PC. When 'msc 1' is set up, the "simple client" thing already sees things set up and skips putting up AS and ASP again. But the msc->a.sccp_user still needs to point at something to have a sender address for messages sent to this MSC. 'msc 0' has already set up an SCCP user for the local PC, and creating a second one would conflict. So, instead, first look for an already existing SCCP user, only create a local user the first time an MSC is set up on any given cs7 instance. I also thought about iterating the cs7 instances instead of the mscs, but that would be a much larger patch, and is also less flexible (for some reason I don't recall ATM). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6a2710edeb9ba047ae70e6b49d4c2e5f06d41a4e Gerrit-Change-Number: 18504 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 29 May 2020 20:30:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/e683c891/attachment.htm>