This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 ) Change subject: ms_srs: refactor UE state getter functions ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/2/src/osmo_gsm_tester/obj/ms_srs.py File src/osmo_gsm_tester/obj/ms_srs.py: https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/2/src/osmo_gsm_tester/obj/ms_srs.py@309 PS2, Line 309: def is_rrc_idle(self): Reminder: This still need to be addressed as agreed in comments from last version. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/2/src/osmo_gsm_tester/obj/ms_srs.py@319 PS2, Line 319: import re You can import re at the top of the module, it's fine since it comes in standard python. https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535/2/src/osmo_gsm_tester/obj/ms_srs.py@324 PS2, Line 324: return ipv4_addr[0] You are missing a return None if nothing is found (loop ends) (this way it can also be used to make sure no address is assigned :)) -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/18535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I6cd057e34b4df6a1a73695355dd6406d7e039546 Gerrit-Change-Number: 18535 Gerrit-PatchSet: 2 Gerrit-Owner: srs_andre <andre at softwareradiosystems.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Reviewer: srs_andre <andre at softwareradiosystems.com> Gerrit-Comment-Date: Fri, 29 May 2020 14:58:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/0d312bf4/attachment.htm>