Change in osmo-bts[master]: bts-trx: vty: Add 'nominal-tx-power' cmd

[pespin]

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/18579 )


Change subject: bts-trx: vty: Add 'nominal-tx-power' cmd
......................................................................

bts-trx: vty: Add 'nominal-tx-power' cmd

This value will be soon acquired automatically by osmo-bts-trx by asking
over TRXC to new versions of osmo-trx which is the nominal tx power for a given trx.
However, to still be able to work correctly against older versions of
osmo-trx or other TRX implementation (older or current) not supporting
this new TRX comamnd, let's allow the user to force a given value
through VTY for Tx power to work correctly.

Change-Id: Ib1b6f80d3b54afc42db9d358a79582cc619c6ce4
---
M src/osmo-bts-trx/main.c
M src/osmo-bts-trx/trx_vty.c
2 files changed, 18 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/79/18579/1

diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c
index ab0472e..3c1c892 100644
--- a/src/osmo-bts-trx/main.c
+++ b/src/osmo-bts-trx/main.c
@@ -104,8 +104,10 @@
 	bts->variant = BTS_OSMO_TRX;
 	bts->support.ciphers = CIPHER_A5(1) | CIPHER_A5(2) | CIPHER_A5(3);
 
-	/* FIXME: this needs to be overridden with the real hardrware
-	 * value */
+	/* The nominal value is later  overwritten through VTY cmd
+	 * 'nominal-tx-power' if present.
+	 * FIXME: In the future, we want osmo-trx to provide us with this info
+	 * through TRXC. */
 	bts->c0->nominal_power = 23;
 
 	gsm_bts_set_feature(bts, BTS_FEAT_GPRS);
diff --git a/src/osmo-bts-trx/trx_vty.c b/src/osmo-bts-trx/trx_vty.c
index 9c67a7f..6fb4aa1 100644
--- a/src/osmo-bts-trx/trx_vty.c
+++ b/src/osmo-bts-trx/trx_vty.c
@@ -160,6 +160,18 @@
 	return CMD_SUCCESS;
 }
 
+DEFUN(cfg_trx_nominal_power, cfg_trx_nominal_power_cmd,
+	"nominal-tx-power <0-100>",
+	"Set the nominal transmit output power in dBm\n"
+	"Nominal transmit output power level in dBm\n")
+{
+	struct gsm_bts_trx *trx = vty->index;
+
+	trx->nominal_power = atoi(argv[0]);
+
+	return CMD_SUCCESS;
+}
+
 DEFUN_DEPRECATED(cfg_phy_ms_power_loop, cfg_phy_ms_power_loop_cmd,
 	"osmotrx ms-power-loop <-127-127>", OSMOTRX_STR
 	"Enable MS power control loop\nTarget RSSI value (transceiver specific, "
@@ -583,6 +595,8 @@
 	install_element_ve(&show_transceiver_cmd);
 	install_element_ve(&show_phy_cmd);
 
+	install_element(TRX_NODE, &cfg_trx_nominal_power_cmd);
+
 	install_element(PHY_NODE, &cfg_phy_ms_power_loop_cmd);
 	install_element(PHY_NODE, &cfg_phy_no_ms_power_loop_cmd);
 	install_element(PHY_NODE, &cfg_phy_timing_advance_loop_cmd);

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18579
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib1b6f80d3b54afc42db9d358a79582cc619c6ce4
Gerrit-Change-Number: 18579
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200529/c0e8c743/attachment.htm>