Change in osmo-mgw[master]: osmo-mgw: refactor endpoint and trunk handling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

dexter gerrit-no-reply at lists.osmocom.org
Thu May 28 17:57:59 UTC 2020


Hello pespin, Jenkins Builder, 

I'd like you to reexamine a change. Please visit

    https://gerrit.osmocom.org/c/osmo-mgw/+/18372

to look at the new patch set (#4).

Change subject: osmo-mgw: refactor endpoint and trunk handling
......................................................................

osmo-mgw: refactor endpoint and trunk handling

The trunk and endpoint handling in osmo-mgw is still very complex and
implemented in various places (mostly mgcp_protocol.c). Also we use
still integers for endpoint identification, which is not flexible enough
to address timeslots/subslots on an E1 trunk. Some refactoring is needed.

 - get rid of integers as endpoint identifiers, use strings instead and
   find the endpoint based on its string name on the trunk.

 - identify the trunk based on the trunk prefix given in the endpoint
   name.

 - rename struct mgcp_trunk_config to struct mgcp_trunk and the related
   symbol name "tcfg" to "trunk" in order to better match the reality.

 - refactor trunk and endpoint allocation. Aggregate functionality in
   in mgcp_endp.c and mgcp_trunk.c. Also remove non-reusable code that
   relates to the still exisiting, but unfinished E1 trunk support.

 - refactor rate counters, put them into a separate module and do no
   longer allocate them per trunk. Allocate them globally instead.

 - get rid of deprecated trunk parameters (leftovers from the
   osmo-bsc_mgcp implementation)

Change-Id: Ice8aaf03faa2fd99074f8665eea3a696d30c5eb3
Related: OS#2659
---
M include/osmocom/mgcp/Makefile.am
M include/osmocom/mgcp/mgcp.h
M include/osmocom/mgcp/mgcp_common.h
M include/osmocom/mgcp/mgcp_endp.h
M include/osmocom/mgcp/mgcp_internal.h
A include/osmocom/mgcp/mgcp_ratectr.h
A include/osmocom/mgcp/mgcp_trunk.h
M src/libosmo-mgcp/Makefile.am
M src/libosmo-mgcp/mgcp_codec.c
M src/libosmo-mgcp/mgcp_conn.c
M src/libosmo-mgcp/mgcp_endp.c
M src/libosmo-mgcp/mgcp_msg.c
M src/libosmo-mgcp/mgcp_network.c
M src/libosmo-mgcp/mgcp_osmux.c
M src/libosmo-mgcp/mgcp_protocol.c
A src/libosmo-mgcp/mgcp_ratectr.c
M src/libosmo-mgcp/mgcp_sdp.c
A src/libosmo-mgcp/mgcp_trunk.c
M src/libosmo-mgcp/mgcp_vty.c
M src/osmo-mgw/mgw_main.c
M tests/mgcp/mgcp_test.c
21 files changed, 964 insertions(+), 774 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/72/18372/4
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18372
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ice8aaf03faa2fd99074f8665eea3a696d30c5eb3
Gerrit-Change-Number: 18372
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/a22f8279/attachment.htm>


More information about the gerrit-log mailing list