Change in osmo-bts[master]: vty: Fix misleading define name

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Thu May 28 17:56:22 UTC 2020


pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/18557 )

Change subject: vty: Fix misleading define name
......................................................................

vty: Fix misleading define name

define contains strings about dB vs mdB, not dB vs dBm.

Change-Id: Ib2f1f9429d7d5ead585fb93195a890abd568e65c
---
M src/common/vty.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  neels: Looks good to me, approved



diff --git a/src/common/vty.c b/src/common/vty.c
index 2cf3224..c2cbeb5 100644
--- a/src/common/vty.c
+++ b/src/common/vty.c
@@ -692,7 +692,7 @@
 }
 
 
-#define DB_DBM_STR 							\
+#define DB_MDB_STR 							\
 	"Unit is dB (decibels)\n"					\
 	"Unit is mdB (milli-decibels, or rather 1/10000 bel)\n"
 
@@ -710,7 +710,7 @@
 	cfg_trx_user_gain_cmd,
 	"user-gain <-100000-100000> (dB|mdB)",
 	"Inform BTS about additional, user-provided gain or attenuation at TRX output\n"
-	"Value of user-provided external gain(+)/attenuation(-)\n" DB_DBM_STR)
+	"Value of user-provided external gain(+)/attenuation(-)\n" DB_MDB_STR)
 {
 	struct gsm_bts_trx *trx = vty->index;
 
@@ -723,7 +723,7 @@
 DEFUN(cfg_trx_pr_max_initial, cfg_trx_pr_max_initial_cmd,
 	"power-ramp max-initial <0-100000> (dBm|mdBm)",
 	PR_STR "Maximum initial power\n"
-	"Value\n" DB_DBM_STR)
+	"Value\n" DB_MDB_STR)
 {
 	struct gsm_bts_trx *trx = vty->index;
 
@@ -736,7 +736,7 @@
 DEFUN(cfg_trx_pr_step_size, cfg_trx_pr_step_size_cmd,
 	"power-ramp step-size <1-100000> (dB|mdB)",
 	PR_STR "Power increase by step\n"
-	"Step size\n" DB_DBM_STR)
+	"Step size\n" DB_MDB_STR)
 {
 	struct gsm_bts_trx *trx = vty->index;
 

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/18557
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f1f9429d7d5ead585fb93195a890abd568e65c
Gerrit-Change-Number: 18557
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/2c3ec205/attachment.htm>


More information about the gerrit-log mailing list