This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18548 ) Change subject: fixup pcu/GPRS_Components: do not duplicate existing functions ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18548/2/pcu/GPRS_Components.ttcn File pcu/GPRS_Components.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18548/2/pcu/GPRS_Components.ttcn@286 PS2, Line 286: rr_imm_ass := f_establish_tbf(ms.ra, ms.ra_is_11bit, ms.burst_type, ms.ta); So with your changes we are basically adding a new layer of abstraction, which is something which I was precisely trying to avoid by dropping old functions, in order for later to be able to access BTS port in a better way to handle stuff in parallel. You are simply undoing my changes which will somehow need work on later. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18548/2/pcu/PCU_Tests.ttcn File pcu/PCU_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18548/2/pcu/PCU_Tests.ttcn@288 PS2, Line 288: var OCT4 tlli := f_rnd_octstring(4); So let's back again to having several variables all around on each test. Hurray! -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/18548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If6c0b8796500e96525b7b1cadb61ab2fc84b4744 Gerrit-Change-Number: 18548 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <axilirator at gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Thu, 28 May 2020 15:48:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20200528/5781b919/attachment.htm>